Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict URI gem to < 0.11.0 #142

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Restrict URI gem to < 0.11.0 #142

merged 1 commit into from
Sep 15, 2022

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Sep 15, 2022

The URI gem has changed its public API with this version, breaking compatibility with the largely unmaintained data_uri gem. This fixes the co-dependency issue for now; once this PR in data_uri is merged we can update to the newest uri gem:

dball/data_uri#10

Copy link
Collaborator

@pelargir pelargir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending RuboCop fix.

The URI gem has changed its public API with this version, breaking
compatibility with the largely unmaintained `data_uri` gem. This fixes
the co-dependency issue for now; once this PR in `data_uri` is merged we
can update to the newest `uri` gem:

dball/data_uri#10
@mamhoff mamhoff merged commit cf6b121 into main Sep 15, 2022
@mamhoff mamhoff deleted the restrict-uri branch September 15, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants