Merge pull request #33 from friendlycart/better-pallet-deprecations

Better pallet deprecations
friendlycart · Dec 20, 2023 · f8f9559 · f8f9559
2 parents 34f14fc + f2fbf20
commit f8f9559
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/lib/physical/shipment.rb b/lib/physical/shipment.rb
@@ -19,11 +19,8 @@ def initialize(id: nil, origin: nil, destination: nil, service_code: nil, pallet
       @structures = structures
       @packages = packages
       @options = options
-
-      return unless pallets.any?
-
-      warn "[DEPRECATION] `pallets` is deprecated.  Please use `structures` instead."
       @pallets = pallets
+      warn "[DEPRECATION] `pallets` is deprecated.  Please use `structures` instead." if pallets.any?
     end
   end
 end
diff --git a/lib/physical/spec_support/factories/shipment_factory.rb b/lib/physical/spec_support/factories/shipment_factory.rb
@@ -4,7 +4,6 @@
   factory :physical_shipment, class: "Physical::Shipment" do
     origin { FactoryBot.build(:physical_location) }
     destination { FactoryBot.build(:physical_location) }
-    pallets { build_list(:physical_pallet, 1) } # deprecated, will be removed
     packages { build_list(:physical_package, 2) }
     service_code { "usps_priority_mail" }
     initialize_with { new(**attributes) }