Generate imposters from swagger #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a new Generate command to generate imposters from swagger. The command addresses many typical use cases but will need to be extended further to cover specialist use cases. Works towards friendsofgo#64.
joanlopez
requested changes
Oct 20, 2021
There was a problem hiding this comment.
Hey @stoovon,
Before performing a review in-depth, could you remove the vendor folder from the changes present on your this pull request, please? We rely on Go Modules without vendoring, so the vendor folder should not be included.
I've also changed the target branch to v0.5.0 as stated on contribution docs.
Thanks! 🙏🏻
|
Thanks @joanlopez. I did develop against |
|
@joanlopez a belated happy new year! Ready for re-review if you have time 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new Generate command to generate imposters from swagger.
The command addresses many typical use cases but will need to be
extended further to cover specialist use cases.
Works towards #64.