Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to opentelemetry-rust v0.26.0 #90

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Oct 14, 2024

Thank you for authoring this crate! This PR upgrades opentelemetry-application-insights to use opentelemetry-rust v0.26.0.

The relevant changes in the new version are:

  • removal of AggregationSelector
  • a new KeyValue API to replace Key

In addition, I also included a couple of clippy fixes in this PR related to vec![] usage.

@frigus02
Copy link
Owner

Oh, thank you. I meant to do that but it kinda dropped of my radar. I'll have a closer look at your PR tomorrow.

src/lib.rs Outdated Show resolved Hide resolved
Copy link
Owner

@frigus02 frigus02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks a lot. I just had to fix the tests. Will release a new version in a few minutes.

@frigus02 frigus02 merged commit e41d0f9 into frigus02:main Oct 15, 2024
1 check passed
@frigus02
Copy link
Owner

Released version 0.36.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants