This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimmlegate
changed the title
Path request response match
[NeedDiscuss]: Path request response match
Jul 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage ? 95.55%
=========================================
Files ? 52
Lines ? 1597
Branches ? 465
=========================================
Hits ? 1526
Misses ? 70
Partials ? 1 Continue to review full report at Codecov.
|
aimmlegate
changed the title
[NeedDiscuss]: Path request response match
Path request response match
Jul 24, 2021
Open new one #131 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to discuss this rule, right now it's nonfunctional and can deal only with basic cases
For example, we have this kind of code
How do we plane handle cases like that? If we want correctly check all nested models this rule would grow quite big and complex.
Should we deal with this at all for MVP?