Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Path request response match #78

Closed
wants to merge 83 commits into from
Closed

Conversation

aimmlegate
Copy link
Collaborator

@aimmlegate aimmlegate commented Jul 17, 2021

Need to discuss this rule, right now it's nonfunctional and can deal only with basic cases

For example, we have this kind of code

PATCH /endpoint ModelUpdate
  => ModelResponse

ModelResponse {
  entity: Model,
}

Model {
  field1: string,
  field2: number
}

ModelUpdate {
  entity: {
    field1: string,
    field2: number
  },
}

How do we plane handle cases like that? If we want correctly check all nested models this rule would grow quite big and complex.
Should we deal with this at all for MVP?

@aimmlegate aimmlegate closed this Jul 17, 2021
@aimmlegate aimmlegate reopened this Jul 17, 2021
@aimmlegate aimmlegate changed the title Path request response match [NeedDiscuss]: Path request response match Jul 17, 2021
@aimmlegate aimmlegate closed this Jul 23, 2021
@aimmlegate aimmlegate reopened this Jul 24, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@20d91c6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #78   +/-   ##
=========================================
  Coverage          ?   95.55%           
=========================================
  Files             ?       52           
  Lines             ?     1597           
  Branches          ?      465           
=========================================
  Hits              ?     1526           
  Misses            ?       70           
  Partials          ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d91c6...16943c2. Read the comment docs.

@aimmlegate aimmlegate changed the title [NeedDiscuss]: Path request response match Path request response match Jul 24, 2021
@aimmlegate aimmlegate closed this Jul 24, 2021
@aimmlegate
Copy link
Collaborator Author

Open new one #131

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[validation] Response and Request dtos should have similar primitive types
3 participants