Increase accuracy of year rollover date calculations #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The days offset was sometimes incorrect as the time of the timestamp was affecting the diff(xx, 'days') call. The time is now stripped off before calculating day difference - The wrong term was selected for events just before the start of easter and lent terms. I've changed the term calculation to use the nearest term to the timestamp, so (for example) events in weeks -1 are handled correctly
An external dataset of the timestamps of various days in the academic year is used.
|
Thanks a bunch Hal, I've tweaked some things so it matches our styleguide and merged this into my rollover branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives grasshopper the same rollover behaviour as Timetable 3.
The command which generates the dataset used in the tests is available here: CUL-DigitalServices/timetable-3#1