Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/membership pages #22

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Feature/membership pages #22

merged 4 commits into from
Nov 16, 2020

Conversation

adamkudrna
Copy link
Member

Pro otestování funkcionality:

image

image

Více viditelného obsahu na telefonech – před a po:

image

image

@adamkudrna adamkudrna added the feature New feature or request label Nov 15, 2020
@adamkudrna adamkudrna requested a review from dlouhak November 15, 2020 21:43
@adamkudrna adamkudrna self-assigned this Nov 15, 2020
assets/scss/04-generic/_theme.scss Outdated Show resolved Hide resolved
assets/scss/06-objects/_section.scss Show resolved Hide resolved
members/signin.hbs Outdated Show resolved Hide resolved
post.hbs Outdated

{{!-- Facebook SDK for comments --}}
<div id="fb-root"></div>
<script async defer crossorigin="anonymous" src="https://connect.facebook.net/cs_CZ/sdk.js#xfbml=1&version=v3.3"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z těchto předgenerovaných kódů od třetích stran jsem pořád zmatená ― proč tam musí být obojí? Nestačil by jen async v našem případě?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skript je sice v zápatí, takže ty atributy se nevyužijí úplně naplno, ale přesto aspoň trochu – pokud vím. async odblokuje renderování, defer odloží vykonání skriptu po načtení a sníží prioritu načítání. Dokonce bych řekl, že je bezpečné takovýhle skript dát do head.

Myslím, že ve skriptech by se dalo někdy uklidit, v tom duchu je založená issue #4. Tak či onak bych to nechal, přijde mi to správně.

Copy link
Member

@dlouhak dlouhak Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Už se mi podařilo si najít odpověď:

The defer attribute may be specified even if the async attribute is specified, to cause legacy Web browsers that only support defer (and not async) to fall back to the defer behavior instead of the synchronous blocking behavior that is the default.

Určitě bych to teď neřešila. Tohle byla taková řečnická otázka, ke které bych se ráda v budoucnu vrátila, klidně až v rámci issue.

partials/members/feedback-success.hbs Show resolved Hide resolved
package.json Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the feature/membership-pages branch from bf90fd1 to 423bb48 Compare November 16, 2020 11:21
@adamkudrna adamkudrna merged commit f3a36ea into main Nov 16, 2020
@adamkudrna adamkudrna deleted the feature/membership-pages branch November 16, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants