Eventpage content #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraSmirnova
requested changes
Oct 30, 2024
| margin: 5px 0; | ||
| } | ||
|
|
||
| .event_actionsDiv { |
There was a problem hiding this comment.
Лучше не использовать названия тега в селекторе ("div", "span" и т д) так как если вам понадобится поменять тег вы вряд ли полезете в css менять название класса, и это может сбивать с толку. Просто actions тут достаточно
| margin: 10px; | ||
| } | ||
|
|
||
| .event__leftPart { |
There was a problem hiding this comment.
Названия leftPart, rightPart не подходят для элемента
Рекомендую к прочтению: https://ru.bem.info/methodology/quick-start/
|
|
||
| renderEvent(event){ | ||
| console.log(event); | ||
| console.log(event.title); |
There was a problem hiding this comment.
давайте отладочную инфу убирать в мр) можно настроить правило в линтере чтобы не пушить лишние console.log
| /** render event */ | ||
| this.renderEvent(event); | ||
| //this.leftPart = document.createElement('leftPart'); | ||
| //this.rightPart = document.createElement('rightPart'); |
There was a problem hiding this comment.
Закоменченный код тоже лучше в main не вливать
…mail-ru/2024_2_Komanda7 into eventpage_content
…2024_2_Komanda7 into eventpage_content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавила:
-отдельный модуль для fetch-запросов на бэк;
-страницу мероприятия