Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update the COPY command in the Dockerfile to copy the destination directory to './' instead of '.' #9

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

imoken777
Copy link
Contributor

Types of changes

What kind of change does this PR introduce? (check at least one)

  • Breaking change
  • Bugfix
  • Feature
  • Code style update
  • Refactoring
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

DockerfileCOPYコマンドのディレクトリ指定は末尾が/で終わっていなければならないため以下を修正

COPY package.json package-lock.json .

表示されていたエラー

When using COPY with more than one source file, the destination must be a directory and end with a / or a \dockerfile-utils(23)

Screenshot 2024-07-13 022143

参照: docker公式ドキュメントよりhttps://docs.docker.com/reference/dockerfile/#copy

If multiple resources are specified, either directly or due to the use of a wildcard, then must be a directory, and it must end with a slash ./

Copy link
Member

@solufa solufa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは知らなかった、LGTM

@solufa solufa merged commit d6192a2 into frouriojs:main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants