Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSONAPI standart #216

Closed
wants to merge 43 commits into from
Closed

Support JSONAPI standart #216

wants to merge 43 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2016

Related to #208

Documentation: https://fs-rails-base-api-pr-216.herokuapp.com/docs

Notable changes:

  • JSONAPI::Utils gem was added
  • JSONAPI::Resource now replacing Serializers
  • Updated routing with JSONAPI support
  • Custom extensions for JSONAPI was added
  • Provided signout endpoint
  • Users CRUD endpoints
  • TodoItems CRUD endpoints
  • Application and users policy

Progress list:

  • Add JSONAPI::Utils gem
  • Replace routes
  • Replace serializers with resources
  • Add custom failure app for Devise
  • Add custom Devise auth strategy
  • Support JSON API with responders
  • Add content-type and required fields to docs
  • Create required test helpers
  • Fix tests
  • Add signout endpoint
  • Add users CRUD endpoints
  • Add more seeds
  • Add TodoItem CRUD endpoints
  • Update docs
  • Deploy fork to Heroku
  • Update Readme

@dmitrytrager
Copy link
Contributor

@AlexeyKuznetzov time has come
let's update with master

@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 December 15, 2016 22:46 Inactive
@dmitrytrager
Copy link
Contributor

@AlexeyKuznetzov deploy app should be ready, have fun

@timurvafin
Copy link
Member

Could we use https://github.com/fs/rails-api-format to store custom responder, warden failure app, warden strategy?

@ghost
Copy link
Author

ghost commented Dec 19, 2016

@timurvafin Yes, we can move all the lib stuff to gem. However, the whole rails-api-format gem should be rewritten for this purpose.

@@ -1,5 +1,12 @@
require "./lib/jsonapi/responder"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to add this /lib/jsonapi to autoload path in application.rb?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, maybe.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 09:19 Inactive
@timurvafin timurvafin had a problem deploying to fs-rails-base-api-pr-216 March 24, 2017 09:21 Failure
@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 09:24 Inactive
@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 09:42 Inactive
@timurvafin timurvafin had a problem deploying to fs-rails-base-api-pr-216 March 24, 2017 09:56 Failure
@timurvafin timurvafin had a problem deploying to fs-rails-base-api-pr-216 March 24, 2017 10:35 Failure
@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 10:55 Inactive
@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 11:45 Inactive
@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 11:57 Inactive
@timurvafin timurvafin temporarily deployed to fs-rails-base-api-pr-216 March 24, 2017 12:11 Inactive
@ghost ghost changed the title [WIP] Support JSONAPI standart Support JSONAPI standart Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants