Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rspec #5

Closed
wants to merge 1 commit into from
Closed

Fix rspec #5

wants to merge 1 commit into from

Conversation

ildarkayumov
Copy link

Updates for api_taster gem

@timurvafin
Copy link
Member

@ildarkayumov what is the reason for this change?

@ildarkayumov
Copy link
Author

#4

These changes solve this problem

@timurvafin
Copy link
Member

@ildarkayumov as I can see you switched api taster to fs/api_taster version on the change_load_path branch.
Could it be merged to master branch at fs or directly to original version?

@ildarkayumov
Copy link
Author

Original version: he does not want to merge for some unknown reason
fredwu/api_taster#43

Fs-version: yes, it could be merged...but we need to update master of fs/api_taster, because it's different from original:

https://github.com/fs/api_taster/commits/master
https://github.com/fredwu/api_taster/commits/master

@@ -43,7 +43,7 @@ group :test do
end

group :development, :staging do
gem 'api_taster', git: '[email protected]:fredwu/api_taster.git'
gem 'api_taster', git: '[email protected]:fs/api_taster.git', branch: 'change_load_path'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semaphore get errors
prefer next record
gem 'api_taster', github: 'fs/api_taster', branch: 'change_load_path'
or
gem 'api_taster', git: 'git://github.com/fs/api_taster.git', branch: 'change_load_path'

@ildarkayumov
Copy link
Author

@timurvafin Please, update https://github.com/fs/api_taster from https://github.com/fredwu/api_taster, and then it could be merged to master branch at fs.

Now, we can’t automatically merge these branches )

@vast vast closed this Sep 24, 2013
@timurvafin timurvafin deleted the fix_rspec branch November 19, 2013 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants