Fix CentOS/RHEL fact #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regardless of whether it's installed or not. The result is that all nodes contain a fact that implies that the latest available redis version seems to be installed. This change switches from using yum to rpm to query the locally installed package database. It has the added benefit of not querying yum, which can be costly. Addresses fsalum#39 in part.
|
We use the version fact to use the correct redis.conf template. This change would break that. |
|
I think using rpm instead of yum makes a lot of sense, since a broken yum install or network connection could cause this fact to hang and timeout. I think running rpm instead of yum would be more efficient. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version fact currently supplies the available redis version regardless of whether it's installed or not. The result is that all nodes contain a fact that implies that the latest available redis version seems to be installed.
This change switches from using yum to rpm to query the locally installed package database. It has the added benefit of not querying yum, which can be costly.
Addresses #39 in part.