Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support scoped CSS in templates by default (#336) #337

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Tarmil
Copy link
Member

@Tarmil Tarmil commented Nov 20, 2023

This fixes #336.

  • Node.Elt is now compatible with scoped CSS.
  • HTML Templates are now compatible with scoped CSS by default. This is done by disabling the use of PlainHtml for subtrees that don't contain any holes, so that all elements are rendered using Node.Elt.
  • A new static parameter optimizePlainHtml: bool re-enables this optimization. It is off by default, and turning it on is incompatible with scoped CSS.

@Tarmil Tarmil self-assigned this Nov 20, 2023
@Tarmil Tarmil force-pushed the templating-scoped-css branch from b4ec52c to fb9fdb3 Compare November 20, 2023 13:23
@Tarmil Tarmil merged commit 9a7481c into releases/v0.23 Nov 20, 2023
7 checks passed
@Tarmil Tarmil deleted the templating-scoped-css branch November 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant