Add login form for admin that uses OIDC #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonegk
force-pushed
the
oidc_login_form
branch
from
4f71c4a to
e176b59
Compare
lilioid
requested changes
Feb 14, 2024
There was a problem hiding this comment.
You can fix the CI by only copying the templates directory and not having it be rendered with cookiecutter. (Cookiecutter and django clash because they both use jinja for templating).
See the cookiecutter docs.
lilioid
reviewed
Feb 14, 2024
...kiecutter.project_slug }}/src/{{ cookiecutter.project_slug }}/core/templates/core/login.html
Show resolved
Hide resolved
lilioid
force-pushed
the
oidc_login_form
branch
from
136fe79 to
e5f33c3
Compare
lilioid
force-pushed
the
oidc_login_form
branch
from
e5f33c3 to
ee7c89e
Compare
lilioid
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template code is from
django/contrib/admin/templates/admin/login.html.Looks like this:
I decided to keep the error notes because they might still be relevant.