Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assertion failure when using Host Device #32

Closed
wants to merge 1 commit into from

Conversation

adriansr
Copy link
Contributor

Passing a device ID of zero (Host device) to FSEventsCopyUUIDForDevice
causes the following assertion failure error to be printed to the logs:

(FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'

@codecov-io
Copy link

codecov-io commented Nov 14, 2017

Codecov Report

Merging #32 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   71.18%   71.28%   +0.09%     
==========================================
  Files           3        3              
  Lines         288      289       +1     
==========================================
+ Hits          205      206       +1     
  Misses         61       61              
  Partials       22       22
Impacted Files Coverage Δ
fsevents.go 79.48% <100%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9a50f...27bdb44. Read the comment docs.

@drewwells
Copy link
Contributor

@adriansr sorry nobody has looked at this. Can you please rebase on master and see if the tests pass?

@drewwells
Copy link
Contributor

This github conflict editor is nonsense. Please rebase this branch to get upgraded travis tests for 1.10.

@adriansr
Copy link
Contributor Author

@drewwells it's rebased now. Thanks for looking at this :)

@patsoffice
Copy link

@adriansr this PR does not fix the assertion message. Applying your patch and changing the test to use dev id 0 results in the same error message:

2018-07-17 22:04 fsevents.test[23666] (FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'

@adriansr
Copy link
Contributor Author

@patsoffice I clearly have broken something.

It seems on May I sent a different fix and for some reason overwrote this branch. Let me see if I can find the original.

Passing a device ID of zero (Host device) to FSEventsCopyUUIDForDevice
causes the following assertion failure error to be printed to the logs:

(FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'
@adriansr
Copy link
Contributor Author

@patsoffice now it's ok

Have a look at #39 too

@patsoffice
Copy link

@adriansr thanks. Fortuntely, I haven't come across the problems you're fixing in #39 (yet).

@adriansr
Copy link
Contributor Author

adriansr commented Jul 23, 2018

Closed in favor of @patsoffice PR #38 which is more complete

@adriansr adriansr closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants