Sonar issues

fugerit-org · Aug 21, 2024 · 7eabc95 · 7eabc95
1 parent 4663e02
commit 7eabc95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/fj-doc-maven-plugin/src/main/java/org/fugerit/java/doc/project/facade/VersionCheck.java b/fj-doc-maven-plugin/src/main/java/org/fugerit/java/doc/project/facade/VersionCheck.java
@@ -17,7 +17,7 @@ private VersionCheck() {}
 
     public static String findFromPropsFile( String path ) {
         Properties props = PropsIO.loadFromClassLoaderSafe( path );
-        if ( props != null && props.containsKey( "version" ) ) {
+        if ( props.containsKey( "version" ) ) {
             String latest = props.getProperty( "version" );
             log.info( "findVersion() latest : {}", latest );
             return latest;

diff --git a/...maven-plugin/src/test/java/test/org/fugerit/java/doc/project/facade/TestVersionCheck.java b/...maven-plugin/src/test/java/test/org/fugerit/java/doc/project/facade/TestVersionCheck.java
@@ -11,15 +11,16 @@
 @Slf4j
 public class TestVersionCheck {
 
-    private static String V_8_6_2 = "8.6.2";
+    private static final String V_8_6_2 = "8.6.2";
 
     @Test
     public void testVersionCheck() {
-        Assert.assertTrue(VersionCheck.isMajorThan( V_8_6_2, "8.6.1" ));
+        Assert.assertTrue(VersionCheck.isMajorThan( V_8_6_2, "8.6.1-SNAPSHOT" ));
         Assert.assertFalse(VersionCheck.isMajorThan( "8.5.1", "8.5.2" ));
         VenusContext context = new VenusContext( new File( "target" ), V_8_6_2, "base" );
         Assert.assertFalse( context.isPreVersion862() );
         log.info( "version from null to : {}", VersionCheck.findVersion( null ) );
+        log.info( "version from null to : {}", VersionCheck.findVersion( VersionCheck.LATEST ) );
         Assert.assertEquals( V_8_6_2, VersionCheck.findFromPropsFile( "maven/pom.properties" ) );
     }