Fix issue with a big YAML with emoji

fugerit-org · Sep 17, 2024 · ebcfd6c · ebcfd6c
1 parent d713629
commit ebcfd6c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -6,8 +6,8 @@
     </properties>
     <body>
         <release version="2.4" date="in GIT" description="Maintenance">
-            <action dev="asomov" type="add"  issue="1098">
-                Add a test for parsing emoji from string (thanks to Madalin Ilie)
+            <action dev="asomov" type="fix"  issue="1098">
+                Fix issue with a big YAML with emoji (thanks to Madalin Ilie)
             </action>
             <action dev="asomov" type="add"  issue="1097">
                 Refactor Scanner to improve performance (thanks to David Schlosnagle)

diff --git a/src/main/java/org/yaml/snakeyaml/reader/StreamReader.java b/src/main/java/org/yaml/snakeyaml/reader/StreamReader.java
@@ -175,7 +175,7 @@ private boolean ensureEnoughData(int size) {
 
   private void update() {
     try {
-      int read = stream.read(buffer);
+      int read = stream.read(buffer, 0, buffer.length - 1); // FIXME why -1 ???
       if (read > 0) {
         int cpIndex = (dataLength - pointer);
         dataWindow = Arrays.copyOfRange(dataWindow, pointer, dataLength + read);

diff --git a/src/test/java/org/yaml/snakeyaml/issues/issue1098/OpenApiTest.java b/src/test/java/org/yaml/snakeyaml/issues/issue1098/OpenApiTest.java
@@ -40,12 +40,8 @@ public void loadAsInputStream() {
   public void loadAsString() {
     String str = Util.getLocalResource("issues/issue1098-openapi.yaml");
     Yaml yaml = new Yaml();
-    try {
-      yaml.load(str);
-      fail("Use stream to parse emoji");
-    } catch (IndexOutOfBoundsException e) {
-      // FIXME
-    }
+    Map<String, Object> sourceTree = yaml.load(str);
+    assertEquals(5, sourceTree.size());
   }
 
   @Test