Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PopScope tests #236

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Add PopScope tests #236

merged 5 commits into from
Aug 31, 2024

Conversation

fujidaiti
Copy link
Owner

@fujidaiti fujidaiti commented Aug 31, 2024

Description

Added regression tests for #233 and pinned Flutter version to v3.22.3 for development and CI. This downgrade was necessary as tests fail with Flutter 3.24+ due to a breaking change, which caused that issue.

The fix for #233 is not included here as it requires Flutter 3.24+, while the main branch will use v3.22.3 post-merge. To accommodate this version disparity, the fix will be implemented in a separate branch, providing distinct solutions for users of Flutter 3.24+ and 3.22.3 or earlier.

Summary (check all that apply)

  • Modified / added code
  • Modified / added tests
  • Modified / added examples
  • Modified / added others (pubspec.yaml, workflows, etc...)
  • Updated README
  • Contains breaking changes
    • Created / updated migration guide
  • Incremented version number
    • Updated CHANGELOG

@fujidaiti fujidaiti self-assigned this Aug 31, 2024
@fujidaiti fujidaiti marked this pull request as ready for review August 31, 2024 19:57
@fujidaiti fujidaiti merged commit 362f2fd into main Aug 31, 2024
9 checks passed
@fujidaiti fujidaiti deleted the add-popscope-test branch August 31, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant