-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support on-screen keyboard #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because sheet itself already has the same functionality.
…tor of sub classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes and new features to address the issue of the keyboard overlap on the sheet. Once the PR is merged, the framework will automatically offset the sheet by the keyboard height to prevent the content from being overlapped by the keyboard.
Changes made
Breaking changes
SheetMetrics.viewportDimensions
fromSize
toViewportDimensions
, which holds theMediaQueryData.viewInsets
of the window (typically the keyboard height) in addition to the viewport size.Internal changes
SheetViewport
to gradually offset the sheet by the keyboard height._ContentScrollDrivenSheetActivity
into the 3 parts according to the lifecycle;_ContentIdleScrollSheetActivity
,_ContentUserScrollSheetActivity
and_ContentBallisticScrollSheetActivity
.UserDragSheetActivity
and_ContentUserScrollSheetActivity
to keep the visual position of the sheet unchanged while a keyboard dismissing/appearing animation is running.New features
resizeToAvoidBottomInset
property toSheetContentScaffold
.Documentation
SheetKeyboardDismissBehavior
.SheetKeyboardDismissBehavior
to the README.