Feat: additional --use-enums flag #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide an option to use typescript enums instead of object literals.
|
thanks again for your contributions! We previously moved away from TS Enums to object literals in #11 but i will still review this since im ok with that being an optional flag |
Thank you so much for considering my contribution! I'm happy to make adjustments if needed based on your review. If you decide not to go through with it, that's totally okay too. Looking forward to your feedback! |
tcampbPPU
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--use-enumsflag to the command-line options. This option will use typescript enums instead of object literals.A 'const' initializer in an ambient context must be a string or numeric literal or literal enum referenceRelated Issues:
Before:
After:
