Fixed code analysis issues

funfair-tech · Dec 10, 2023 · 097da91 · 097da91
1 parent 489ab94
commit 097da91
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/src/FunFair.BuildVersion.Detection/PreReleaseTagBuilder.cs b/src/FunFair.BuildVersion.Detection/PreReleaseTagBuilder.cs
@@ -15,12 +15,9 @@ internal static class PreReleaseTagBuilder
 
     public static StringBuilder NormalizeSourceBranchName(this string currentBranch, IBranchClassification branchClassification)
     {
-        if (branchClassification.IsPullRequest(currentBranch: currentBranch, out long pullRequestId))
-        {
-            return new("pr-" + pullRequestId.ToString(CultureInfo.InvariantCulture));
-        }
-
-        return new(currentBranch.ToLowerInvariant());
+        return new(branchClassification.IsPullRequest(currentBranch: currentBranch, out long pullRequestId)
+                       ? "pr-" + pullRequestId.ToString(CultureInfo.InvariantCulture)
+                       : currentBranch.ToLowerInvariant());
     }
 
     public static StringBuilder ReplaceInvalidCharacters(this StringBuilder suffix)

diff --git a/src/FunFair.BuildVersion.Publishers/GitHubActionsVersionPublisher.cs b/src/FunFair.BuildVersion.Publishers/GitHubActionsVersionPublisher.cs
@@ -14,10 +14,9 @@ public void Publish(NuGetVersion version)
         if (!string.IsNullOrEmpty(env))
         {
             File.AppendAllLines(path: env,
-                                new[]
-                                {
-                                    $"BUILD_VERSION={version}"
-                                });
+            [
+                $"BUILD_VERSION={version}"
+            ]);
         }
     }
 }
diff --git a/src/FunFair.BuildVersion/EnumExtensions.cs b/src/FunFair.BuildVersion/EnumExtensions.cs
@@ -10,4 +10,5 @@ namespace FunFair.BuildVersion;
 [SuppressMessage(category: "ReSharper", checkId: "PartialTypeWithSinglePart", Justification = "Needed for generated code")]
 internal static partial class EnumExtensions
 {
+    // Code generated
 }