Skip to content

Commit

Permalink
[Cleanup] - Code cleanup on FunFair.BuildVersion.sln
Browse files Browse the repository at this point in the history
  • Loading branch information
credfeto committed Dec 11, 2023
1 parent ff37130 commit c6b2756
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions src/FunFair.BuildVersion.Detection/GitBranchDiscovery.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ public sealed class GitBranchDiscovery : IBranchDiscovery
private readonly ILogger<GitBranchDiscovery> _logger;
private readonly Repository _repository;

public GitBranchDiscovery(Repository repository, IBranchClassification branchClassification, IEnumerable<IExternalBranchLocator> externalBranchLocators, ILogger<GitBranchDiscovery> logger)
public GitBranchDiscovery(Repository repository,
IBranchClassification branchClassification,
IEnumerable<IExternalBranchLocator> externalBranchLocators,
ILogger<GitBranchDiscovery> logger)
{
this._repository = repository ?? throw new ArgumentNullException(nameof(repository));
this._branchClassification = branchClassification ?? throw new ArgumentNullException(nameof(branchClassification));
Expand All @@ -39,7 +42,7 @@ public string FindCurrentBranch()

foreach (Branch candidateBranch in this._repository.Branches)
{
if (!StringComparer.Ordinal.Equals(candidateBranch.FriendlyName, branch) && StringComparer.Ordinal.Equals(candidateBranch.Tip.Sha, sha))
if (!StringComparer.Ordinal.Equals(x: candidateBranch.FriendlyName, y: branch) && StringComparer.Ordinal.Equals(x: candidateBranch.Tip.Sha, y: sha))
{
this._logger.LogInformation($"Found Branch for PR {pullRequestId} : {candidateBranch.FriendlyName}");

Expand Down
2 changes: 1 addition & 1 deletion src/FunFair.BuildVersion/FunFair.BuildVersion.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<PackageReference Include="SmartAnalyzers.CSharpExtensions.Annotations" Version="4.2.8" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.15.0.81779" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="ThisAssembly.AssemblyInfo" Version="1.4.1" PrivateAssets="All" ExcludeAssets="runtime"/>
<PackageReference Include="ThisAssembly.AssemblyInfo" Version="1.4.1" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="ToStringWithoutOverrideAnalyzer" Version="0.6.0" PrivateAssets="All" ExcludeAssets="runtime" />
</ItemGroup>
</Project>

0 comments on commit c6b2756

Please sign in to comment.