Skip to content

Commit

Permalink
Correcting lint errors (#447)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the Title above that
includes the Jira Ticket -->

# Description
<!--- Describe your changes in detail -->

# Related Issue\Feature
<!--- Please link to the issue or feature: -->

# How Has This Been Tested
- [ ] All unit tests pass.
- [ ] All integration tests pass.
- [ ] Manual Testing:
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

# Types of changes
<!--- What types of changes does your code introduce? Put an 'x' in all
the boxes that apply: -->
<!-- Note that you can just click these after submission and it will
remember the tick for you -->
- [ ] Docs change
- [ ] Refactoring
- [ ] Dependency upgrade
- [ ] Additional Unit Tests\Integration Tests
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Removed no-longer used code

## Deployment Configuration Changes
- [ ] Requires deployment configuration changes as specified below and
in CHANGELOG.md
<!--- Insert Deployment configuration changes here -->

# Checklist
<!--- Go over all the following points, and put an 'x' in all the boxes
once they are true. -->
<!-- Note that you can just click these after submission and it will
remember the tick for you -->
- [ ] There are no Resharper\static code analysis errors anywhere in the
solution.
- [ ] I have ONLY run a code clean-up on any files I have modified to
make sure they are in the correct format and no others.
- [ ] I have added tests to cover my changes.
- [ ] I have run the code and quickly verified it all works to my
satisfaction.
- [ ] All new/modified code has sufficient logging to be able to
diagnose what is wrong.
- [ ] All new and existing tests passed.
- [ ] All new/modified public interfaces/classes have are documented
with xmldoc comments.
- [ ] Unreleased section of CHANGELOG.md has been updated with details
of this PR.
  • Loading branch information
credfeto authored Jun 10, 2024
2 parents ce222c4 + 603b258 commit 5281236
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/dotnet-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ jobs:
echo "Requested dotnet version: ${{env.DOTNET_VERSION}}"
- name: "Switch to version branch"
if: ${{env.DOTNET_VERSION}} < ${{steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}
if: ${{env.DOTNET_VERSION < steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}
shell: bash
run: |
git checkout "depends/dotnet/${{env.NEW_DOTNET_VERSION}}" || git checkout -b "depends/dotnet/${{env.NEW_DOTNET_VERSION}}"
env:
NEW_DOTNET_VERSION: ${{steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}

- name: "Update global.json to latest version"
if: ${{env.DOTNET_VERSION}} < ${{steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}
if: ${{env.DOTNET_VERSION < steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}
shell: bash
working-directory: src
run: |
Expand All @@ -107,7 +107,7 @@ jobs:
NEW_DOTNET_VERSION: ${{steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}

- name: "Commit changes to new branch"
if: ${{env.DOTNET_VERSION}} < ${{steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}
if: ${{env.DOTNET_VERSION < steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}
uses: stefanzweifel/[email protected]
with:
commit_message: "SDK - Update DotNet SDK to ${{steps.latest-dotnet-version.outputs.LATEST_RELEASE_VERSION}}"
Expand Down

0 comments on commit 5281236

Please sign in to comment.