only 10 dispatch parameters allowed - use CLOUDFORMATION_SNS_ARN thro…

…ugh vars
funfair-tech · Nov 19, 2024 · 90a1c47 · 90a1c47
1 parent 2b9b45e
commit 90a1c47
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 21 deletions.
diff --git a/.github/actions/build/action.yml b/.github/actions/build/action.yml
@@ -100,9 +100,6 @@ inputs:
   CLOUD_FORMATION_STACK:
     description: 'The Cloud Formation stack to deploy as'
     required: true
-  CLOUDFORMATION_SNS_ARN:
-    description: 'SSN Notification ARN'
-    required: false
 
   # DOCKER
   DOCKER_USERNAME:
@@ -441,7 +438,6 @@ runs:
       with:
         CLOUD_FORMATION_STACK: ${{inputs.CLOUD_FORMATION_STACK}}
         CLOUD_FORMATION_TEMPLATE_FILE: "cloudformation.json"
-        CLOUDFORMATION_SNS_ARN: ${{inputs.CLOUDFORMATION_SNS_ARN}}
         BUILD_VERSION: ${{env.BUILD_VERSION}}
         DOCKER_APP_OWNER: ${{inputs.DOCKER_APP_OWNER}}
         DOCKER_APP_NAME: ${{inputs.DOCKER_APP_NAME}}

diff --git a/.github/actions/cloudformation-deploy/action.yml b/.github/actions/cloudformation-deploy/action.yml
@@ -8,9 +8,6 @@ inputs:
   CLOUD_FORMATION_TEMPLATE_FILE:
     description: 'The Cloud Formation file to deploy'
     required: true
-  CLOUDFORMATION_SNS_ARN:
-    description: 'SSN Notification ARN'
-    required: false
   DOCKER_APP_OWNER:
     description: 'docker app owner'
     required: true
@@ -82,11 +79,11 @@ runs:
     - name: "show Validated TemplateParameters"
       shell: bash
       run: |
-        echo "SNS ARN: ${{inputs.CLOUDFORMATION_SNS_ARN}}"
+        echo "SNS ARN: ${{vars.CLOUDFORMATION_SNS_ARN}}"
         echo "Validated parameters:"
         jq . "${{github.workspace}}/TemplateParameters.json"
 
-    - if: inputs.CLOUDFORMATION_SNS_ARN != ''
+    - if: vars.CLOUDFORMATION_SNS_ARN != ''
       name: "AWS Cloudformation Deploy (With Notifications)"
       shell: bash
       run: |
@@ -99,12 +96,12 @@ runs:
                         --parameter-overrides \
                               file://TemplateParameters.json \
                         --notification-arns \
-                              "${{inputs.CLOUDFORMATION_SNS_ARN}}" \
+                              "${{vars.CLOUDFORMATION_SNS_ARN}}" \
                         --tags \
                               "App=${{inputs.CLOUD_FORMATION_STACK}}" \
                               "Version=${{inputs.BUILD_VERSION}}"
 
-    - if: inputs.CLOUDFORMATION_SNS_ARN == ''
+    - if: vars.CLOUDFORMATION_SNS_ARN == ''
       name: "AWS Cloudformation Deploy (No Notifications)"
       shell: bash
       run: |

diff --git a/.github/actions/dispatch-deploy/action.yml b/.github/actions/dispatch-deploy/action.yml
@@ -8,9 +8,6 @@ inputs:
   CLOUD_FORMATION_TEMPLATE_FILE:
     description: 'The Cloud Formation file to deploy'
     required: true
-  CLOUDFORMATION_SNS_ARN:
-    description: 'SSN Notification ARN'
-    required: false
   DOCKER_APP_OWNER:
     description: 'docker app owner'
     required: true
@@ -47,7 +44,6 @@ runs:
       shell: bash
       run: |
         echo "CLOUD_FORMATION_STACK: ${{inputs.CLOUD_FORMATION_STACK}}"
-        echo "CLOUDFORMATION_SNS_ARN: ${{inputs.CLOUD_FORMATION_STACK}}"
         echo "CLOUD_FORMATION_TEMPLATE_FILE: ${{inputs.CLOUD_FORMATION_TEMPLATE_FILE}}"
         echo "DOCKER_APP_OWNER: ${{inputs.DOCKER_APP_OWNER}}"
         echo "DOCKER_APP_NAME: ${{inputs.DOCKER_APP_NAME}}"
@@ -70,7 +66,6 @@ runs:
             ref: 'main',
             inputs: {
                 CLOUD_FORMATION_STACK: "${{inputs.CLOUD_FORMATION_STACK}}",
-                CLOUDFORMATION_SNS_ARN: "${{inputs.CLOUD_FORMATION_STACK}}",
                 CLOUD_FORMATION_TEMPLATE_FILE: "${{inputs.CLOUD_FORMATION_TEMPLATE_FILE}}",
                 DOCKER_APP_OWNER: "${{inputs.DOCKER_APP_OWNER}}",
                 DOCKER_APP_NAME: "${{inputs.DOCKER_APP_NAME}}",

diff --git a/.github/workflows/build-and-publish-pre-release.yml b/.github/workflows/build-and-publish-pre-release.yml
@@ -89,7 +89,6 @@ jobs:
           DOCKER_APP_NAME: ${{vars.DOCKER_APP_NAME}}
           CLOUD_FORMATION_DEPLOY: ${{vars.CLOUD_FORMATION_DEPLOY}}
           CLOUD_FORMATION_STACK: ${{vars.CLOUD_FORMATION_STACK}}
-          CLOUDFORMATION_SNS_ARN: ${{vars.CLOUDFORMATION_SNS_ARN}}
           GITHUB_TOKEN: ${{secrets.SOURCE_PUSH_TOKEN}}
           REPO_VISIBILITY: ${{env.REPO_STATUS}}
           AWS_ACCESS_KEY_ID: ${{secrets.AWS_DOCKER_CONTAINER_REGISTRY_ACCESS_KEY_ID}}
@@ -138,7 +137,6 @@ jobs:
           DOCKER_APP_NAME: ${{vars.DOCKER_APP_NAME}}
           CLOUD_FORMATION_DEPLOY: ${{vars.CLOUD_FORMATION_DEPLOY}}
           CLOUD_FORMATION_STACK: ${{vars.CLOUD_FORMATION_STACK}}
-          CLOUDFORMATION_SNS_ARN: ${{vars.CLOUDFORMATION_SNS_ARN}}
           GITHUB_TOKEN: ${{secrets.SOURCE_PUSH_TOKEN}}
           REPO_VISIBILITY: ${{env.REPO_STATUS}}
           AWS_ACCESS_KEY_ID: ${{secrets.AWS_DOCKER_CONTAINER_REGISTRY_ACCESS_KEY_ID}}

diff --git a/.github/workflows/build-and-publish-release.yml b/.github/workflows/build-and-publish-release.yml
@@ -80,7 +80,6 @@ jobs:
           DOCKER_APP_NAME: ${{vars.DOCKER_APP_NAME}}
           CLOUD_FORMATION_DEPLOY: ${{vars.CLOUD_FORMATION_DEPLOY}}
           CLOUD_FORMATION_STACK: ${{vars.CLOUD_FORMATION_STACK}}
-          CLOUDFORMATION_SNS_ARN: ${{vars.CLOUDFORMATION_SNS_ARN}}
           GITHUB_TOKEN: ${{secrets.SOURCE_PUSH_TOKEN}}
           REPO_VISIBILITY: ${{env.REPO_STATUS}}
           AWS_ACCESS_KEY_ID: ${{secrets.AWS_DOCKER_CONTAINER_REGISTRY_ACCESS_KEY_ID}}
@@ -129,7 +128,6 @@ jobs:
           DOCKER_APP_NAME: ${{vars.DOCKER_APP_NAME}}
           CLOUD_FORMATION_DEPLOY: ${{vars.CLOUD_FORMATION_DEPLOY}}
           CLOUD_FORMATION_STACK: ${{vars.CLOUD_FORMATION_STACK}}
-          CLOUDFORMATION_SNS_ARN: ${{vars.CLOUDFORMATION_SNS_ARN}}
           GITHUB_TOKEN: ${{secrets.SOURCE_PUSH_TOKEN}}
           REPO_VISIBILITY: ${{env.REPO_STATUS}}
           AWS_ACCESS_KEY_ID: ${{secrets.AWS_DOCKER_CONTAINER_REGISTRY_ACCESS_KEY_ID}}

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -82,7 +82,6 @@ jobs:
         uses: ./.github/actions/cloudformation-deploy
         with:
           CLOUD_FORMATION_STACK: ${{inputs.CLOUD_FORMATION_STACK}}
-          CLOUDFORMATION_SNS_ARN: ${{inputs.CLOUDFORMATION_SNS_ARN}}
           CLOUD_FORMATION_TEMPLATE_FILE: "${{github.workspace}}/${{inputs.CLOUD_FORMATION_TEMPLATE_FILE}}"
           DOCKER_APP_OWNER: ${{inputs.DOCKER_APP_OWNER}}
           DOCKER_APP_NAME: ${{inputs.DOCKER_APP_NAME}}