Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirmRegistration should return response rather than always true #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjmeyer-polymorph
Copy link
Contributor

Good day @furaiev, I was wondering if we could do the same as #261 but for confirmRegistration?
That is the function I need right now, but I imagine for others it would be good to also change verifyAttribute, changePassword, enableMfa, disableMfa, updateAttributes, deleteAttributes, and deleteUser in the same way since they all return true always.
Possibly setUserMfaPreference should also rethrow inside the catch, instead of returning false as it does now.

@furaiev
Copy link
Owner

furaiev commented Dec 31, 2024

hello @cjmeyer-polymorph ,
I'm wondering if it makes sense to catch, to do nothing and to rethrow.
It is actually the same behavior as we have right now - without catching.

It makes sense only if we catch and return false for example.

@cjmeyer-polymorph
Copy link
Contributor Author

Sorry you're right, I didn't realise the error would bubble up and be able to be caught

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants