Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create database_read.py #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create database_read.py #197

wants to merge 1 commit into from

Conversation

HKev68
Copy link

@HKev68 HKev68 commented Oct 1, 2016

Database_read build the fut players database and enables you to find the name of player when you know its id and vice-versa

Database_read build the fut players database and enables you to find the name of player when you know its id and vice-versa
@oczkers
Copy link
Member

oczkers commented Oct 3, 2016

I like the idea but i think it should be much simple (read json directly, not convert to html then parse, convert unicode) and merged into core as new function.
What's the point of creating new file?

@HKev68
Copy link
Author

HKev68 commented Oct 4, 2016

I created a new file as I did not want to mess up all your work when I created this library.
I also thought that it will be way faster if I only parse the json file once, and store the result in a structure than parsing for each request

oczkers added a commit that referenced this pull request Oct 4, 2016
@converge
Copy link

I solve this problem, importing the JSON content into my database. When I need find some player assetId, I find then at my database.

@oczkers do you have some better idea ?

@oczkers
Copy link
Member

oczkers commented Jan 10, 2017

Looks like i've started parsing json databse but totally forget about this :-)

TODO:

  • import json
  • parse and arrange in nice dictionary/object for easy searching like in HKev68 code

@oczkers
Copy link
Member

oczkers commented Apr 28, 2017

Players data is parsed now (f1ceb1c).

TODO:

  • objects, we need objects (player, nationality, team etc.)
  • add database search abilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants