Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old buildtag #2072

Merged
merged 1 commit into from
Dec 2, 2024
Merged

refactor: remove old buildtag #2072

merged 1 commit into from
Dec 2, 2024

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

As of Go 1.18, the old build tag form // +build is deprecated. Remove it.

$ go fix -fix buildtag ./...

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n requested a review from shino December 2, 2024 02:19
@MaineK00n MaineK00n self-assigned this Dec 2, 2024
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@MaineK00n MaineK00n merged commit 1ab4c79 into master Dec 2, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/patch-1 branch December 2, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants