feat(grammar): Expose wildcard imports as named nodes #130
Conversation
Parse "." and "*" for wildcard imports as separate nodes, allowing them to be more precisely highlighted. Create a new named node `wildcard_import`.
|
I've only notice now that a similar pull request was opened (#122). But something different is that my implementation exposes |
| @@ -167,11 +167,13 @@ module.exports = grammar({ | |||
|
|
|||
| import_header: $ => seq( | |||
| "import", | |||
| $.identifier, | |||
| optional(choice(seq(".*"), $.import_alias)), | |||
There was a problem hiding this comment.
Note that this construct (single child seq rule) is currently broken on tree-sitter master, so this (or a similar) change is needed to keep being able to generate a compatible parser.
|
@fwcd @VladimirMakaev what's the current maintenance situation with this parser? I see a number of (even necessary) maintenance PRs being left unmerged, and I worry that sooner or later this parser will become unusable for downstream like Neovim. |
It's maintained, but not super actively (at least on my part), largely due to a lack of spare time and other important projects. PRs are always welcome though, smaller ones are more likely to be merged quickly. |
|
Please regenerate the parser on an x86_64 Linux machine: #92 The simplest way to do that is in CI using the "Regenerate Parser" action, which should be available in your fork too (if not, leave a note). Docker also works. |
|
That is not the issue; the problem is that the CI is using a different (outdated?) tree-sitter version. (Regenerating with current tree-sitter versions -- which do make a difference, especially in recent versions -- is exactly part of the parser maintenance I was referring to above.) |
|
The CI should use the same version of tree-sitter as the package, that is 0.22.1, and I would strongly recommend using the Updating to 0.22.6 is planned, but, as mentioned above, we have to be a bit careful about not breaking e.g. the playground by just bumping the version: |
If you need help with maintenance, we'd be happy to adopt it under tree-sitter-grammars. |
|
That's very nice, thanks, but I still prefer to keep it here for now. I originally put a lot of work into writing this grammar and also maintain the packages under my name, so I'd like to keep the canonical version here for now. Feel free to fork it into your organization if that suits your workflow! |
|
I mean you will keep maintaining it and the packages just as before, but have more hands on deck. In any case, I'm personally fine with helping out whether it's here or there. |
|
Thanks! |
Parse "." and "*" for wildcard imports as separate nodes, allowing them to be more precisely highlighted.
Create a new named node
wildcard_import.