Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend scanner.c to correctly parse strings of the form "*\$" #137

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Amend scanner.c to correctly parse strings of the form "*\$" #137

merged 4 commits into from
Aug 2, 2024

Conversation

yosefAlsuhaibani
Copy link
Contributor

For some reason, the scan_string_content cannot parse a string that has an escaped dollar sign at the end of the string, like abc\$ or \$; I've included a very small fix to scanner.c that solves this.

@github-actions github-actions bot added the scanner Related to the external scanner label Aug 1, 2024
fwcd
fwcd reviewed Aug 2, 2024
View reviewed changes
Copy link
Owner

@fwcd fwcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! Just a minor nit, otherwise this looks good.

test/corpus/literals.txt Show resolved Hide resolved
@yosefAlsuhaibani @fwcd
Update test/corpus/literals.txt
b5ce081 
fix test style

Co-authored-by: fwcd <[email protected]>
@yosefAlsuhaibani
Copy link
Contributor Author

Of course: thank you for maintaining this parser!

@fwcd fwcd merged commit 754394c into fwcd:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwcd fwcd Awaiting requested review from fwcd

Assignees
No one assigned
Labels
scanner Related to the external scanner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yosefAlsuhaibani @fwcd