Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tree-sitter crate dependency to >=0.21 #150

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

alexle0nte
Copy link
Contributor

@github-actions github-actions bot added the bindings Related to the Node.js/Rust/C bindings label Sep 27, 2024
@marco-c
Copy link

marco-c commented Oct 31, 2024

@fwcd or @VladimirMakaev could you take a look?

@HerringtonDarkholme
Copy link
Contributor

BTW, tree-sitter 0.24.0 also introduced a new breaking change to, say, not introduce breaking change.

https://github.com/tree-sitter/tree-sitter-html/pull/107/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542

the new tree-sitter-language will be a standalone crate stable enough to not relying on tree-sitter library itself.

Cargo.toml Outdated
@@ -21,7 +21,7 @@ include = [
path = "bindings/rust/lib.rs"

[dependencies]
tree-sitter = ">= 0.21, < 0.23"
tree-sitter = "0.23"
Copy link

@wetneb wetneb Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in tree-sitter 0.24 are actually backwards compatible, meaning that tree-sitter 0.24 works with grammars written for tree-sitter 0.23. So I think it would be very helpful to relax the dependency constraint and let folks use the parser with newer versions of tree-sitter:

Suggested change
tree-sitter = "0.23"
tree-sitter = ">=0.23"

(or even >=0.21 if you want to support older versions too)

@alexle0nte alexle0nte changed the title Bump tree-sitter crate dependency to 0.23 Update tree-sitter crate dependency to >=0.21 Nov 25, 2024
@joowani
Copy link

joowani commented Dec 27, 2024

Any update on this? Thanks

@wetneb
Copy link

wetneb commented Jan 13, 2025

@fwcd is anything holding you back from merging this?

If this is still not merged and released in the coming weeks, I am planning to fork this crate into an organization with a governance system to enable people to step in for maintenance tasks like this one.

@wetneb
Copy link

wetneb commented Jan 17, 2025

@ObserverOfTime kindly pointed out to me that another tree-sitter grammar for kotlin is being developed here:
https://github.com/tree-sitter-grammars/tree-sitter-kotlin, so there is no need to make another fork.
Apparently, that grammar is not ready for production use yet, but for my purposes it seems to work well (even better than this one in one respect).

It is uploaded as tree-sitter-kotlin-ng on crates.io and is compatible with tree-sitter 0.23+.

@VladimirMakaev VladimirMakaev merged commit c4ddea3 into fwcd:main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings Related to the Node.js/Rust/C bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants