-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tree-sitter crate dependency to >=0.21 #150
Conversation
@fwcd or @VladimirMakaev could you take a look? |
BTW, tree-sitter 0.24.0 also introduced a new breaking change to, say, not introduce breaking change. the new |
Cargo.toml
Outdated
@@ -21,7 +21,7 @@ include = [ | |||
path = "bindings/rust/lib.rs" | |||
|
|||
[dependencies] | |||
tree-sitter = ">= 0.21, < 0.23" | |||
tree-sitter = "0.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in tree-sitter 0.24 are actually backwards compatible, meaning that tree-sitter 0.24 works with grammars written for tree-sitter 0.23. So I think it would be very helpful to relax the dependency constraint and let folks use the parser with newer versions of tree-sitter:
tree-sitter = "0.23" | |
tree-sitter = ">=0.23" |
(or even >=0.21
if you want to support older versions too)
9c1fa9d
to
9b40bc2
Compare
Any update on this? Thanks |
@fwcd is anything holding you back from merging this? If this is still not merged and released in the coming weeks, I am planning to fork this crate into an organization with a governance system to enable people to step in for maintenance tasks like this one. |
@ObserverOfTime kindly pointed out to me that another tree-sitter grammar for kotlin is being developed here: It is uploaded as tree-sitter-kotlin-ng on crates.io and is compatible with tree-sitter 0.23+. |
9b40bc2
to
0717089
Compare
#148