fix: prevent pnpm crash with Node versions < 16.14

fwouts · May 10, 2023 · 8fe019e · 8fe019e
1 parent 0af237f
commit 8fe019e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/integrations/cli/package.json b/integrations/cli/package.json
@@ -38,6 +38,6 @@
     "typescript": "^5.0.4"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.0.0"
+    "node": "^16.14.0"
   }
 }
diff --git a/...intellij/src/main/kotlin/com/previewjs/intellij/plugin/services/PreviewJsSharedService.kt b/...intellij/src/main/kotlin/com/previewjs/intellij/plugin/services/PreviewJsSharedService.kt
@@ -245,9 +245,9 @@ ${e.stackTraceToString()}""",
         matchResult?.let {
             val majorVersion = matchResult.groups[1]!!.value.toInt()
             val minorVersion = matchResult.groups[2]!!.value.toInt()
-            // Minimum version: 14.18.0.
-            if (majorVersion < 14 || majorVersion == 14 && minorVersion < 18) {
-                throw NodeVersionError("Preview.js needs NodeJS 14.18.0+ to run, but current version is: ${nodeVersion}\n\nPlease upgrade then restart your IDE.")
+            // Minimum version: 16.14.0.
+            if (majorVersion < 16 || majorVersion == 16 && minorVersion < 14) {
+                throw NodeVersionError("Preview.js needs NodeJS 16.14.0+ to run, but current version is: ${nodeVersion}\n\nPlease upgrade then restart your IDE.")
             }
         }
     }

diff --git a/integrations/vscode/src/start-daemon.ts b/integrations/vscode/src/start-daemon.ts
@@ -237,22 +237,22 @@ function checkNodeVersionResult(result: ExecaReturnValue<string>):
       result.exitCode !== 0 ? ` with exit code ${result.exitCode}` : "";
     return {
       kind: "invalid",
-      message: `Preview.js needs NodeJS 14.18.0+ but running \`node\` failed${withExitCode}.\n\nIs it installed? You may need to restart your IDE.\n`,
+      message: `Preview.js needs NodeJS 16.14.0+ but running \`node\` failed${withExitCode}.\n\nIs it installed? You may need to restart your IDE.\n`,
     };
   }
   const nodeVersion = stripAnsi(result.stdout).split("\n").at(-1)!.trim();
   const match = nodeVersion.match(/^v(\d+)\.(\d+).*$/);
   const invalidVersion = {
     kind: "invalid",
-    message: `Preview.js needs NodeJS 14.18.0+ to run.\n\nPlease upgrade then restart your IDE.`,
+    message: `Preview.js needs NodeJS 16.14.0+ to run.\n\nPlease upgrade then restart your IDE.`,
   } as const;
   if (!match) {
     return invalidVersion;
   }
   const majorVersion = parseInt(match[1]!, 10);
   const minorVersion = parseInt(match[2]!, 10);
-  // Minimum version: 14.18.0.
-  if (majorVersion < 14 || (majorVersion === 14 && minorVersion < 18)) {
+  // Minimum version: 16.14.0.
+  if (majorVersion < 16 || (majorVersion === 16 && minorVersion < 14)) {
     return invalidVersion;
   }