Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple previewjs config extensions and add defineConfig() helper #2086

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

fwouts
Copy link
Owner

@fwouts fwouts commented Oct 5, 2023

No description provided.

@fwouts fwouts enabled auto-merge (squash) October 5, 2023 21:30
@fwouts fwouts force-pushed the preview-config-fn branch from 52078a4 to e463857 Compare October 5, 2023 21:32
@fwouts fwouts disabled auto-merge October 5, 2023 21:32
@fwouts fwouts changed the title feat: support both CJS and ESM config files feat: support both multiple previewjs config extensions and add defineConfig() helper Oct 5, 2023
@fwouts fwouts changed the title feat: support both multiple previewjs config extensions and add defineConfig() helper feat: support multiple previewjs config extensions and add defineConfig() helper Oct 5, 2023
@rudolfbyker
Copy link

Will this allow defining different wrappers for different components? Or am I misunderstanding the purpose of this PR?

@fwouts
Copy link
Owner Author

fwouts commented Oct 6, 2023

Hey @rudolfbyker! No, this just allows you to name your config file preview.config.ts or preview.config.mjs or whatever other extension you want.

I'm curious to hear more about your use case for different wrappers for different components though. What do you envision that looking like?

@fwouts fwouts merged commit 4da7d53 into main Oct 6, 2023
15 checks passed
@fwouts fwouts deleted the preview-config-fn branch October 6, 2023 11:18
@rudolfbyker
Copy link

Thanks for your time.

I'm curious to hear more about your use case for different wrappers for different components though. What do you envision that looking like?

See #2107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants