Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid: Small adjustments #47

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Mermaid: Small adjustments #47

merged 10 commits into from
Nov 5, 2024

Conversation

xFrednet
Copy link
Collaborator

@xFrednet xFrednet commented Nov 1, 2024

The list of current changes:

  • Increased font size to 16px
  • Rename nullptr node to None
  • Move region information into the bride object
  • Indicate borrows with dotted arrows
  • Don't draw the immutable region by default
  • Remove info node from Mermaid
  • Show nested regions as subgraphs
  • Add more asserts to cown creation, now that bridge objects have been reified

Example:

image


Closes #35

@xFrednet xFrednet force-pushed the 0-sealions branch 2 times, most recently from e702d50 to beccc35 Compare November 1, 2024 12:32
@xFrednet xFrednet changed the title [WIP] Mermaid: Small adjustments Mermaid: Small adjustments Nov 1, 2024
@xFrednet xFrednet requested a review from mjp41 November 1, 2024 16:58
@xFrednet
Copy link
Collaborator Author

xFrednet commented Nov 1, 2024

This PR should be ready, besides the CI timeout.

I enjoy working on these diagrams :D

@xFrednet xFrednet mentioned this pull request Nov 3, 2024
@xFrednet xFrednet merged commit a6bb947 into main Nov 5, 2024
8 of 10 checks passed
@xFrednet xFrednet deleted the 0-sealions branch November 5, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cowns do not permit regions that have internal back pointers
2 participants