Implicit Freezing and close() functions
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
force-pushed
the
49-implicit-snow-storm
branch
3 times, most recently
from
8f8199f
to
941a510
Compare
xFrednet
force-pushed
the
49-implicit-snow-storm
branch
from
941a510
to
54aadbb
Compare
This was referenced Nov 7, 2024
Closed
mjp41
reviewed
Nov 11, 2024
| @@ -175,10 +175,8 @@ namespace rt::objects | |||
| collecting = true; | |||
|
|
|||
| std::cout << "Starting collection" << std::endl; | |||
There was a problem hiding this comment.
I think using the for here is wrong. The destruct call could modify to_collect, which will (silently) invalidate the iterator.
src/rt/objects/dyn_object.h
Outdated
| template<typename Pre, typename Post> | ||
| inline void visit(Region* start, Pre pre, Post post) | ||
| { | ||
| for (auto obj : start->objects) |
There was a problem hiding this comment.
Could visit modify start->objects?
xFrednet
force-pushed
the
49-implicit-snow-storm
branch
from
4aa0280
to
6fdd340
Compare
xFrednet
force-pushed
the
49-implicit-snow-storm
branch
from
6fdd340
to
cfe6f9d
Compare
|
Good comments, shows that I'm still not used to C++ and why memory safe languages are a good idea... Anyhow, let's get this merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of changes sadly exploded a bit. Most of them are superficial and should hopefully be easy to review.
This PR also changes the stack representation from an
std::vector<>to actual fields called_stack[n]on the frame object. It's not really efficient by any stretch of the imagination, but it allows the invalidation of stack values and works well with our Mermaid output.