Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix dateTimeThisYear method #2039

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fix dateTimeThisYear method #2039

merged 1 commit into from
Oct 23, 2020

Conversation

macaron
Copy link
Contributor

@macaron macaron commented Aug 5, 2020

Fix dateTimeThisYear method in issue #2027

I referred to this document.
https://www.php.net/manual/en/datetime.formats.relative.php#122278

Thank you.

Chomiciak
Chomiciak approved these changes Aug 28, 2020
View reviewed changes
Copy link

@Chomiciak Chomiciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. It is quite interesting how did it happen that someone made such a mistake...

richardkeep
richardkeep approved these changes Oct 1, 2020
View reviewed changes
Copy link

@richardkeep richardkeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@pimjansen pimjansen merged commit 2f538cc into fzaninotto:master Oct 23, 2020
@pimjansen
Copy link
Contributor

Thanks, nice find

@pimjansen pimjansen added this to the 1.9.2 milestone Oct 23, 2020
@pimjansen pimjansen added the bug label Oct 23, 2020
GrahamCampbell pushed a commit to FakerPHP/Faker that referenced this pull request Oct 27, 2020
@macaron @GrahamCampbell
Fix dateTimeThisYear method (fzaninotto#2039)
78a851e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pimjansen pimjansen pimjansen approved these changes

@richardkeep richardkeep richardkeep approved these changes

@Chomiciak Chomiciak Chomiciak approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.9.2
Development

Successfully merging this pull request may close these issues.
4 participants
@macaron @pimjansen @richardkeep @Chomiciak