Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility of CartesianComplianceController with Moveit #41

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

stefanscherzinger
Copy link
Contributor

@stefanscherzinger stefanscherzinger commented Dec 4, 2021

Goal

Users can plan robot end-effector motion with Moveit and execute that with Cartesian compliance in contact.

Approach

Moveit's output is a FollowJointTrajectoryGoal that best integrates with the joint_trajectory_controller. The cartesian_controllers repository already provides a JointControllerAdapter that allows to connect such a joint_trajectory_controller and turn the joint-based trajectory into Cartesian targets via robot forward kinematics. For motion that is sufficiently away from robot singularities, this could provide a suitable approach combine motion planning with compliance.

Steps

  • Test the joint_to_cartesian_controller package with rqt
  • Fix the dangling robot chain
  • Fix possible controller freezes. I remember that one could create a deadlock with the controller's internal controller manager

Resolves #18 , resolves #28

@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from 7d417e4 to 4e22a04 Compare February 13, 2022 21:31
@stefanscherzinger stefanscherzinger marked this pull request as draft February 13, 2022 21:49
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from 60cfffb to fd100ec Compare September 16, 2022 11:36
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from 6500df9 to 091e5ff Compare September 20, 2022 01:39
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from 091e5ff to 046e3c0 Compare October 12, 2022 14:15
@stefanscherzinger stefanscherzinger marked this pull request as ready for review October 12, 2022 14:16
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch 2 times, most recently from bbfd0cd to f411dba Compare October 14, 2022 01:42
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from dfc5aee to 4248dcf Compare July 12, 2023 13:42
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from 4248dcf to 5c3afd1 Compare September 21, 2023 12:54
We now run the adapter's update in a separate thread.
This allows us to start/stop connected joint_trajectory_controllers
even when the adapter is not running.
This better explains our hard-coded control frequency for the adapter
thread.
@stefanscherzinger stefanscherzinger force-pushed the improve-moveit-compatibility branch from 5c3afd1 to fceb47b Compare January 9, 2024 15:42
@stefanscherzinger stefanscherzinger merged commit c3cf703 into master Jan 9, 2024
8 checks passed
@stefanscherzinger stefanscherzinger deleted the improve-moveit-compatibility branch January 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant