fix(service): fix completions of ident with dot

g-plane · Feb 8, 2025 · 1581e05 · 1581e05
1 parent e383f9e
commit 1581e05
Show file tree

Hide file tree

Showing 57 changed files with 2,221 additions and 214 deletions.
diff --git a/crates/service/src/features/completion.rs b/crates/service/src/features/completion.rs
diff --git a/crates/service/tests/completion/snapshots/features__completion__block__block_type.snap b/crates/service/tests/completion/snapshots/features__completion__block__block_type.snap
@@ -9,38 +9,103 @@ expression: response
       "description": "[i32, i32]"
     },
     "kind": 6,
-    "detail": "(if $b (result i32) (result i32))"
+    "detail": "(if $b (result i32) (result i32))",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 9,
+          "character": 23
+        },
+        "end": {
+          "line": 9,
+          "character": 24
+        }
+      },
+      "newText": "$b"
+    }
   },
   {
     "label": "1",
     "labelDetails": {
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block)"
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 9,
+          "character": 23
+        },
+        "end": {
+          "line": 9,
+          "character": 24
+        }
+      },
+      "newText": "1"
+    }
   },
   {
     "label": "2",
     "labelDetails": {
       "description": "[i32]"
     },
     "kind": 6,
-    "detail": "(block (param i32) (param i32) (result i32))"
+    "detail": "(block (param i32) (param i32) (result i32))",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 9,
+          "character": 23
+        },
+        "end": {
+          "line": 9,
+          "character": 24
+        }
+      },
+      "newText": "2"
+    }
   },
   {
     "label": "$a",
     "labelDetails": {
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block $a)"
+    "detail": "(block $a)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 9,
+          "character": 23
+        },
+        "end": {
+          "line": 9,
+          "character": 24
+        }
+      },
+      "newText": "$a"
+    }
   },
   {
     "label": "4",
     "labelDetails": {
       "description": "[i32]"
     },
     "kind": 6,
-    "detail": "(loop (result i32))"
+    "detail": "(loop (result i32))",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 9,
+          "character": 23
+        },
+        "end": {
+          "line": 9,
+          "character": 24
+        }
+      },
+      "newText": "4"
+    }
   }
 ]
diff --git a/crates/service/tests/completion/snapshots/features__completion__block__blocks.snap b/crates/service/tests/completion/snapshots/features__completion__block__blocks.snap
@@ -9,38 +9,103 @@ expression: response
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block $b)"
+    "detail": "(block $b)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 23
+        },
+        "end": {
+          "line": 8,
+          "character": 24
+        }
+      },
+      "newText": "$b"
+    }
   },
   {
     "label": "1",
     "labelDetails": {
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block)"
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 23
+        },
+        "end": {
+          "line": 8,
+          "character": 24
+        }
+      },
+      "newText": "1"
+    }
   },
   {
     "label": "2",
     "labelDetails": {
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block)"
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 23
+        },
+        "end": {
+          "line": 8,
+          "character": 24
+        }
+      },
+      "newText": "2"
+    }
   },
   {
     "label": "$a",
     "labelDetails": {
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block $a)"
+    "detail": "(block $a)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 23
+        },
+        "end": {
+          "line": 8,
+          "character": 24
+        }
+      },
+      "newText": "$a"
+    }
   },
   {
     "label": "4",
     "labelDetails": {
       "description": "[]"
     },
     "kind": 6,
-    "detail": "(block)"
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 23
+        },
+        "end": {
+          "line": 8,
+          "character": 24
+        }
+      },
+      "newText": "4"
+    }
   }
 ]
diff --git a/...vice/tests/completion/snapshots/features__completion__block__blocks_following_dollar.snap b/...vice/tests/completion/snapshots/features__completion__block__blocks_following_dollar.snap
@@ -10,7 +10,61 @@ expression: response
     },
     "kind": 6,
     "detail": "(block $b)",
-    "insertText": "b"
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 24
+        },
+        "end": {
+          "line": 8,
+          "character": 25
+        }
+      },
+      "newText": "$b"
+    }
+  },
+  {
+    "label": "1",
+    "labelDetails": {
+      "description": "[]"
+    },
+    "kind": 6,
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 24
+        },
+        "end": {
+          "line": 8,
+          "character": 25
+        }
+      },
+      "newText": "1"
+    }
+  },
+  {
+    "label": "2",
+    "labelDetails": {
+      "description": "[]"
+    },
+    "kind": 6,
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 24
+        },
+        "end": {
+          "line": 8,
+          "character": 25
+        }
+      },
+      "newText": "2"
+    }
   },
   {
     "label": "$a",
@@ -19,6 +73,39 @@ expression: response
     },
     "kind": 6,
     "detail": "(block $a)",
-    "insertText": "a"
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 24
+        },
+        "end": {
+          "line": 8,
+          "character": 25
+        }
+      },
+      "newText": "$a"
+    }
+  },
+  {
+    "label": "4",
+    "labelDetails": {
+      "description": "[]"
+    },
+    "kind": 6,
+    "detail": "(block)",
+    "textEdit": {
+      "range": {
+        "start": {
+          "line": 8,
+          "character": 24
+        },
+        "end": {
+          "line": 8,
+          "character": 25
+        }
+      },
+      "newText": "4"
+    }
   }
 ]