chore: apply Clippy suggestions

g-plane · Feb 5, 2025 · 3e88a3a · 3e88a3a
1 parent 26508ff
commit 3e88a3a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/crates/server/src/stdio.rs b/crates/server/src/stdio.rs
@@ -35,7 +35,7 @@ pub fn write_sync(message: Message) -> Result<()> {
     let json = serde_json::to_string(&message)?;
     let mut stdout = std::io::stdout().lock();
     write!(stdout, "Content-Length: {}\r\n\r\n", json.len())?;
-    stdout.write_all(&json.as_bytes())?;
+    stdout.write_all(json.as_bytes())?;
     stdout.flush()?;
     event!(Level::DEBUG, "stdout: {json}");
     Ok(())

diff --git a/crates/service/src/binder.rs b/crates/service/src/binder.rs
@@ -56,7 +56,7 @@ fn create_symbol_table(db: &dyn SymbolTablesCtx, uri: InternUri) -> Arc<SymbolTa
                 key: SymbolKey::new(node),
                 green: node.green().into(),
                 region,
-                kind: kind.clone(),
+                kind,
                 idx: Idx {
                     num: None,
                     name: Some(db.ident(ident.text().into())),
@@ -95,7 +95,7 @@ fn create_symbol_table(db: &dyn SymbolTablesCtx, uri: InternUri) -> Arc<SymbolTa
                     .and_then(|immediate| create_ref_symbol(db, immediate.syntax(), region, kind))
                     .unwrap_or_else(|| Symbol {
                         green: node.green().into(),
-                        key: SymbolKey::new(&node),
+                        key: SymbolKey::new(node),
                         region,
                         kind,
                         idx: Idx {
@@ -255,9 +255,10 @@ fn create_symbol_table(db: &dyn SymbolTablesCtx, uri: InternUri) -> Arc<SymbolTa
                 }
             }
             SyntaxKind::PLAIN_INSTR => {
-                let Some(instr) = PlainInstr::cast(node.clone()) else {
+                let Some(instr) = PlainInstr::cast(node) else {
                     continue;
                 };
+                let node = instr.syntax();
                 match instr.instr_name().as_ref().map(|token| token.text()) {
                     Some("call" | "ref.func" | "return_call") => {
                         let Some(region) = node

diff --git a/crates/service/src/checker/dup_names.rs b/crates/service/src/checker/dup_names.rs
@@ -45,7 +45,7 @@ pub fn check(
                         // re-map this symbol kind to make comparison easier
                         SymbolKind::Param
                     } else {
-                        symbol.kind.clone()
+                        symbol.kind
                     };
                     map.entry((name, &symbol.region, kind))
                         .or_insert_with(|| Vec::with_capacity(1))