Add stream getting stock price & refactor

g-viet · Apr 25, 2019 · a41f7a5 · a41f7a5
1 parent 3d35912
commit a41f7a5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/helper.ts b/src/helper.ts
@@ -12,7 +12,7 @@ const fetchStock = async (stockCode: string): Promise<Stock> => {
     const apiCall = () => {
         return new Promise((resolve, reject) => {
             const options = {
-                url: Helper.buildApiUrl(stockCode),
+                url: buildApiUrl(stockCode),
                 method: 'GET',
                 json: true
             };
@@ -28,6 +28,5 @@ const fetchStock = async (stockCode: string): Promise<Stock> => {
 }
 
 export const Helper = {
-    buildApiUrl: buildApiUrl,
     fetchStock: fetchStock
 }
diff --git a/src/index.ts b/src/index.ts
@@ -16,6 +16,7 @@ program
                     return;
                 }
                 Stock.gets(stocks);
+                break;
             case "stream":
                 if (stocks.length == 0) {
                     console.log("You must include stock code!! For example: ");

diff --git a/src/stock_api.ts b/src/stock_api.ts
@@ -3,18 +3,19 @@ import { Helper } from './helper';
 const gets = (stockCodes: string[]) => {
     console.log(`Stock\tPrice\t\tVolume\t\tOpenPrice\tHighestPrice\tLowestPrice\tTime`);
     try {
-        return Promise.all(stockCodes.map(async (code) => {
-            const stock = await Helper.fetchStock(code);
-            stock.printf();
-            return true;
+        return Promise.all(stockCodes.map((code) => {
+            return Helper.fetchStock(code).then(stock => stock.printf());
         }));
     } catch (err) {
         throw err;
     }
 }
 
 const stream = (stockCode: string) => {
-    return;
+    console.log(`Stock\tPrice\t\tVolume\t\tOpenPrice\tHighestPrice\tLowestPrice\tTime`);
+    setInterval(() => {
+        Helper.fetchStock(stockCode).then(stock => stock.printf());
+    }, 2000);
 }
 
 export {