Initial preferred language shared pref support. #40
Conversation
This doesn't yet allow you to set the shared pref, but it does work if you hardcode the language in the code.
|
This is partially operational. You can click the Russian item in the Language select and then navigate elsewhere in the app and the Russian translations apply. Fine to merge if you're OK with the progress. |
| @@ -66,6 +67,15 @@ | |||
| @Override | |||
| protected void onCreate(Bundle savedInstanceState) { | |||
| super.onCreate(savedInstanceState); | |||
| overridePendingTransition(android.R.anim.fade_in, android.R.anim.fade_out); | |||
| PreferredLanguageSupport.applyPreferredLanguage(this); | |||
| final Activity thisActivity = NavigationActivity.this; | |||
There was a problem hiding this comment.
Is this an aesthetic thing? Or is there a technical reason for saving a final reference here? (this is the first time I've seen this pattern)
There was a problem hiding this comment.
I'm transitioning the variable reference from the local scope to effectively member scope in an anon class so it needs to be final in Java. Many times you'll see parameters in methods declared final for this reason as well.
|
Looks good. I'll go ahead and merge so it's easier to use in our time zone. I had a couple informational questions, looking forward to learning more Java 😸 |
No description provided.