i18n stuff #56
Merged
i18n stuff #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a utility for making a CSV of strings to make it easier to solicit
translations
- remove english from uk/ru strings files
- fix a bug that resulted in parts of the app showing the system default
strings, and parts not.
- specifically, `Locale.getDefault()` returns a different locale after
`resources.updateConfiguration()` is called. so if you switch to uk,
then to the system default, `Locale.getDefault()` would return uk,
resulting in the nav not going back to english. i understand that if
the user changes the system language, this app won't reflect that
change, but that seems less bad than a UI showing two different
languages.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translations
strings, and parts not.
Locale.getDefault()returns a different locale afterresources.updateConfiguration()is called. so if you switch to uk,then to the system default,
Locale.getDefault()would return uk,resulting in the nav not going back to english. i understand that if
the user changes the system language, this app won't reflect that
change, but that seems less bad than a UI showing two different
languages.