Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and refactor requirements.txt into multiple files #546

Closed
wants to merge 1 commit into from

Conversation

Raruto
Copy link
Contributor

@Raruto Raruto commented May 5, 2023

Motivation

Allowing docker developers to add a single line inside their entrypoint.sh in order to easily reinstall all necessary python dependencies (without rebuilding a new image), eg:

# g3w-suite-docker/scripts/docker-entrypoint-dev.sh 

if [ ! -e "/shared-volume/build_done" ]; then
  pip3 install -r /code/requirements.txt
fi

List of changes

Refactor the main requirements.txt so it always installs all necessary dependencies (including them from all other files listed here)

# Django
-r ./g3w-admin/core/requirements.txt

# Huey
-r ./g3w-admin/caching/requirements_huey.txt

# Caching
-r ./g3w-admin/caching/requirements.txt

# File manager
-r ./g3w-admin/filemanager/requirements.txt

# Qplotly
-r ./g3w-admin/qplotly/requirements.txt

# Openrouteservice
-r ./g3w-admin/openrouteservice/requirements.txt

Alternative solution

If those dependencies are only useful to docker users, perhaps it would be better to just refactor the requirements_docker.txt file as described above.

Related to: #544 (comment)

@Raruto Raruto added the refactoring Anything which could result in a API change label May 5, 2023
@Raruto Raruto added this to the v3.6 milestone May 5, 2023
@wlorenzetti wlorenzetti modified the milestones: v3.6, v3.7 May 24, 2023
@wlorenzetti wlorenzetti removed this from the v3.7 milestone Nov 29, 2023
@wlorenzetti wlorenzetti deleted the requirements-txt branch March 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants