Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eval expression response json #990

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Eval expression response json #990

merged 4 commits into from
Dec 11, 2024

Conversation

wlorenzetti
Copy link
Member

Refactoring of response of /api/expression_eval/<int:project_id>/ with a standard G3W-SUITE API Json response, i.e.:

From a response body like this

'GUATEMALA'

To a Json response body like this:

{'result': True, 'value': "GUATEMALA"}

@wlorenzetti wlorenzetti added the refactoring Anything which could result in a API change label Dec 11, 2024
@wlorenzetti wlorenzetti added this to the v3.9 milestone Dec 11, 2024
@wlorenzetti wlorenzetti self-assigned this Dec 11, 2024
@wlorenzetti wlorenzetti marked this pull request as ready for review December 11, 2024 14:05
@wlorenzetti wlorenzetti merged commit 43c9858 into dev Dec 11, 2024
5 checks passed
@wlorenzetti wlorenzetti deleted the eval_expression_response_json branch December 11, 2024 14:05
volterra79 added a commit to g3w-suite/g3w-client that referenced this pull request Dec 11, 2024
@volterra79
✨ Referred to g3w-suite/g3w-admin#990
1392731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volterra79 volterra79 volterra79 approved these changes

Assignees

@wlorenzetti wlorenzetti

Labels
refactoring Anything which could result in a API change
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.
2 participants
@wlorenzetti @volterra79