Icon arrow direction on Streetview map control #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e las one property is used to avoid to reset initial starting rotation when resolution change due to zoom in zoom out of the map
Raruto
reviewed
Feb 14, 2023
Comment on lines
+42
to
+53
| /** | ||
| * Object contain previuos data referred to : | ||
| * - rotation: for array rotation | ||
| * - resolution: map view resolution | ||
| * - position: lat lng of streetview | ||
| * @type {{rotation: null, position: null, resolution: null}} | ||
| */ | ||
| this.cached = { | ||
| position: [0, 0], | ||
| resolution: null, | ||
| rotation: null | ||
| }; |
There was a problem hiding this comment.
I made some tests, but even so the position seems to me to be often wrong (ie. not so deterministic)
Raruto
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #337