Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove promise return from function ApplicationService::changeProject({ gid, host }) #386

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Mar 21, 2023

No more return promise is used when changeProject is run because location.replace(url) reload page

@volterra79 volterra79 added the refactoring Anything which could result in a API change label Mar 21, 2023
@volterra79 volterra79 added this to the v3.8 milestone Mar 21, 2023
@volterra79 volterra79 self-assigned this Mar 21, 2023
@volterra79 volterra79 requested a review from Raruto March 22, 2023 09:16
@Raruto Raruto modified the milestones: v3.8, v3.9 Mar 23, 2023
@Raruto
Copy link
Collaborator

Raruto commented Mar 23, 2023

Moved to v3.9 because I have the suspect that calling location.replace() the context change isn't so immediate and removing the promised return from the changeProject() function might break something else (ie. anything like changeProject().then(...)).

Remember to check better when we get closer to:

@Raruto Raruto removed their request for review March 23, 2023 10:24
@Raruto Raruto changed the title Remove promise from change Project Remove promise return from function ApplicationService::changeProject() Mar 23, 2023
@Raruto Raruto changed the title Remove promise return from function ApplicationService::changeProject() Remove promise return from function ApplicationService::changeProject({ gid, host }) Mar 23, 2023
@Raruto Raruto marked this pull request as draft July 21, 2023 07:24
@volterra79 volterra79 modified the milestones: v3.9, v4.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants