Move "g3w-ol/g3w.ol" into "gui/map/mapservice"
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete useless file: `src/app/g3w-ol/g3w.ol.js` - move `src/app/g3w-ol/map/maphelpers.js` into `src/app/gui/map/mapservice.js` - convert internal class to ES6 (OlMapViewer)
…turn filter array methos instead to create new empty array and push filtered vaules
volterra79
approved these changes
Aug 21, 2023
Raruto
commented
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to: #291 and #193
Reducing overall complexity related to the
g3w-olfolder and facilitating a future refactoring of theMapServiceclass.List of changes
src/app/g3w-ol/g3w.ol.js(as it's just a wrapper for theg3w-ol/map/maphelpersmodule)src/app/g3w-ol/map/maphelpers.jsintosrc/app/gui/map/mapservice.js(ie. the only place where it is actually in use)