Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal preview image gets cropped on small screens #499

Merged
merged 9 commits into from
Oct 16, 2023
Merged

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Oct 11, 2023

Closes: #497

List of changes

Refactored .main-sidebar container (left sidebar) so that it doesn't create a new stacking context before the .content-wrapper (right sidebar and parent of modal container).

Before

<aside class="main-sidebar">          <-- old "position: absolute;"
  <a class="sidebar-aside-toggle"></a>
  <div id="g3w-sidebar"></div>
</aside>
<div class="content-wrapper">
 <div id="gallery_1697199677167"></div>
</div>

After

<aside class="main-sidebar">
  <a class="sidebar-aside-toggle"></a>
  <div class="main-sidebar">          <-- new "position: absolute;"
    <div id="g3w-sidebar"></div>
  </div>
</aside>
<div class="content-wrapper">
 <div id="gallery_1697199677167"></div>
</div>

Before

Screenshot from 2023-10-11 12-06-56

After

Screenshot from 2023-10-11 12-09-54

Close sidebar button is still visible when right panel has 100% width

Screenshot from 2023-10-11 14-58-13

…tain relations and after time it remove a layers related to this relation
@volterra79 volterra79 added the bug Something isn't working label Oct 11, 2023
@volterra79 volterra79 added this to the v3.9 milestone Oct 11, 2023
@volterra79 volterra79 self-assigned this Oct 11, 2023
@volterra79 volterra79 marked this pull request as draft October 11, 2023 11:55
@volterra79 volterra79 marked this pull request as ready for review October 11, 2023 13:09
@volterra79 volterra79 requested a review from Raruto October 11, 2023 13:09
@volterra79 volterra79 marked this pull request as draft October 12, 2023 07:00
@volterra79 volterra79 marked this pull request as ready for review October 12, 2023 08:02
Copy link
Collaborator

@Raruto Raruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volterra79 I'm struggle to understand what it has been done here (e.g. moved modal container under another father?, changed some other containers z-index?).

Please add some info about it in within PR description (or at least a reference to CSS classes of the containers that I should double check).

@volterra79 volterra79 requested a review from Raruto October 13, 2023 08:31
Copy link
Collaborator

@Raruto Raruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to do extensive testing on it, it works anyway 👍

@volterra79 volterra79 merged commit a8ec492 into dev Oct 16, 2023
@volterra79 volterra79 deleted the issue_497 branch October 16, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal preview image gets cropped on small screens
2 participants