-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal preview image gets cropped on small screens #499
Conversation
…tain relations and after time it remove a layers related to this relation
… avoid to be hide when open right content menu to 100%.
… of main-header class and not child
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volterra79 I'm struggle to understand what it has been done here (e.g. moved modal container under another father?, changed some other containers z-index?).
Please add some info about it in within PR description (or at least a reference to CSS classes of the containers that I should double check).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to do extensive testing on it, it works anyway 👍
Closes: #497
List of changes
Refactored
.main-sidebar
container (left sidebar) so that it doesn't create a new stacking context before the .content-wrapper (right sidebar and parent of modal container).Before
After
Before
After
Close sidebar button is still visible when right panel has 100% width