Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor G3WObject, Panel and Component classes #574

Merged
merged 400 commits into from
Apr 19, 2024

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Feb 9, 2024

Depends on g3w-suite/g3w-admin#787

Motivation

  1. Make it easier for other plugin developers to understand how internal components work.
  2. Start addressing Figure out how to deprecate internal components #547
  3. Allow plugins to use ES6 classes (brings dff014d from Refactor GUI class #451)

Abstract

  • move class definition from gui/utils/barstack.js into core/g3w-barstack.js
  • move class definition from gui/component/component.js into core/g3w-component.js
  • move class definition from gui/panel.js into core/g3w-panel.js
  • new file component/g3w-catalog.js
  • new file component/g3w-changemapmenu.js
  • new file component/g3w-contentsviewer.js
  • new file component/g3w-form.js
  • new file component/g3w-map.js
  • new file component/g3w-metadata.js
  • new file component/g3w-print.js
  • new file component/g3w-projectsmenu.js
  • new file component/g3w-querybuilder.js
  • new file component/g3w-queryresults.js
  • new file component/g3w-relationspage.js
  • new file component/g3w-search.js
  • new file component/g3w-spatialbookmarks.js
  • new file component/g3w-tools.js
  • new file component/g3w-wms.js
  • deprecate setting search_endpoint = 'ows' (until removal, the new default is: 'api')

Related to: #193

@Raruto Raruto added the refactoring Anything which could result in a API change label Feb 9, 2024
@Raruto Raruto added this to the v3.10 milestone Feb 9, 2024
@Raruto Raruto requested a review from volterra79 February 9, 2024 09:07
@Raruto Raruto changed the title Refactor Panel and Component classes Refactor G3WObject, Panel and Component classes Feb 19, 2024
@Raruto
Copy link
Collaborator Author

Raruto commented Mar 5, 2024

@volterra79 please avoid rewriting g3w-* components too much (eg. d40f577, ca6c011), they don't look nice but there are some reasons why are written/proposed in a such a way..

@volterra79 volterra79 marked this pull request as draft March 6, 2024 14:35
@Raruto
Copy link
Collaborator Author

Raruto commented Mar 8, 2024

@volterra79 🥲 sometimes using more specific descriptions would help others analyze/find your edits.

image

@Raruto Raruto marked this pull request as ready for review April 9, 2024 13:41
Raruto added a commit to g3w-suite/g3w-admin that referenced this pull request Apr 12, 2024
@Raruto Raruto requested review from volterra79 and removed request for volterra79 April 19, 2024 08:52
src/components/SearchPanel.vue Outdated Show resolved Hide resolved
@Raruto Raruto merged commit 88ef906 into dev Apr 19, 2024
@Raruto Raruto deleted the refactor-panels-and-components branch April 19, 2024 12:32
wlorenzetti pushed a commit to g3w-suite/g3w-admin that referenced this pull request Apr 22, 2024
* move shorten condition at top (if-else)

* ternary assignment

* alias: `field['input']` → `input`

* reduce nesting

* keep a focus on JSON response structure

* comments

* spacing

* client g3w-suite/g3w-client@5bbe9ca

* `widget_serializzer_data` → `w_data`

* client g3w-suite/g3w-client@c08802c

* fix `search_1n`

* TODO

* ✨ Client
  g3w-suite/g3w-client@c8f16e9
  g3w-suite/g3w-client-plugin-editing@fccb0e6

* g3w-suite/g3w-client@b83cdad

* g3w-suite/g3w-client@f797285

* move `layerid` into `WidgetSerializer`

* 🐛 Client
  g3w-suite/g3w-client-plugin-editing@d03671e

* g3w-suite/g3w-client@28435f2

* deprecate `G3W_CLIENT_SEARCH_ENDPOINT`

* g3w-suite/g3w-client@ea6e5ac

* attempt to fix client test

* 🐛 Client
  g3w-suite/g3w-client-plugin-editing@dc37654

* remove initial `values` in within search config

* g3w-suite/g3w-client#574

* tests

* `blanktext` → `description`

* g3w-suite/g3w-client@1f3a8d9

* 🐛 Client
 g3w-suite/g3w-client-plugin-editing@5211bee

* g3w-suite/g3w-client@e108bcd

* g3w-suite/g3w-client@9618ec2

* ✨ Client
  g3w-suite/g3w-client-plugin-editing@0375222

---------

Co-authored-by: volterra79 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants