This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Added objects and fields descriptions #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyenyxe Looks all good to me, but While this is documented in |
|
I can't change the origin branch so I will close this PR and open a new one using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Beacon implementation my team just developed, there were some classes and fields that could welcome extending the documentation.
I am aware the counts are already being discussed in #258 but this PR proposed an alternative description based on this wiki page, and it only applies to the
BeaconDatasetAlleleResponseobjects.