Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when draw-over permission not granted #39

Closed
licaon-kter opened this issue Aug 17, 2017 · 9 comments
Closed

Crash when draw-over permission not granted #39

licaon-kter opened this issue Aug 17, 2017 · 9 comments

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Aug 17, 2017

Steps:

  • have the app installed
  • install some other app
  • grant that app some permissions ( Can't manage apps permissions (overlay issue) #38 )
  • forget that you've toggle OFF the "draw over other app" permission for TapAndTurn
  • see TapAndTurn crash repeatedly ( logcat ) until said permission is granted back

The app needs to cope with the fact that the permission is missing, maybe sprinkle some try{} here or there. :)

@gabm
Copy link
Owner

gabm commented Aug 17, 2017

indeed.. there is something wrong ;) I'll have a look...

@gabm
Copy link
Owner

gabm commented Aug 17, 2017

That should be fixed in next version - TnT switches itself off when it notices that the permission got lost meanwhile...

@gabm gabm closed this as completed Aug 17, 2017
@gabm
Copy link
Owner

gabm commented Aug 18, 2017

this has been released as 2.7.0

@gabm gabm reopened this Aug 18, 2017
@gabm gabm closed this as completed Aug 18, 2017
@Frenzie
Copy link

Frenzie commented Aug 29, 2017

Would there be a sensible manner to try to auto re-enable?

@licaon-kter
Copy link
Contributor Author

Apps can't "auto-grant" themselves permissions...

@Frenzie
Copy link

Frenzie commented Aug 29, 2017

Who's talking about auto-granting? The service quits running because it is temporarily locked out.

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

i think the but discussed here is solved on 2.7.. please either reopen this issue or create a new one...

@Frenzie
Copy link

Frenzie commented Aug 29, 2017

Right, I'm talking about the behavior caused by the fix in c4b42d0.

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

ok, I'll try to guess what u mean:

you are talking about the behavior "when the permission gets lost, then tnt switches itself off"? and you want tnt to auto-reactivate when it gets the permission back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants